Do not remove first char in etag #3274
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Why stripping anything at all? the double quotes are an integral part of the etag.
They should never be removed!
Also note that an etag does not always start with a double quote - see https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/ETag
The etags in the oc10 requests do not contain quotes. This request should be compatible to the oc10 request. |
They do for sure - unless anybody did break anything in oc10 the past months 🙈 |
Here is a preview request from oc10. |
Wow - this is so wrong .... anyway since you are rebuilding oc10 apis 👍 |
|
FYI: on the PROPFIND response there are double quotes ... |
Why is it like that? @DeepDiver1975 |
|
@C0rby @DeepDiver1975 pls let me know about decision if keep/remove. I'd like to have this in today's release so we don't release previews with a bug 🙂 |
the rfc says so 🤷♂️ anyway - this is 'only' on the preview url parameter so I don't care much |
Description
Follow up on #3187. The first char of etag was being removed when stripping away double quotes.