Skip to content
This repository was archived by the owner on Jun 5, 2024. It is now read-only.

Fix file path stripping for favorites, search and tags #985

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Fix file path stripping for favorites, search and tags #985

merged 3 commits into from
Feb 7, 2022

Conversation

JammingBen
Copy link
Contributor

No description provided.

@AlexAndBear AlexAndBear self-requested a review February 7, 2022 09:47
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

pascalwengerter
pascalwengerter approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why CI didn't complain when you did the initial changes, you got any insights on that? :)

@JammingBen
Copy link
Contributor Author

I think because the SDK stripped away /files/username form the response body, and the tests expected exactly that.

@JammingBen JammingBen merged commit 492b923 into master Feb 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-path-stripping branch February 7, 2022 09:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JammingBen @pascalwengerter @AlexAndBear