This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
[tests-only] [full-ci] Bump ocis commit id to latest #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grgprarup
requested review from
SwikritiT,
SagarGi,
saw-jan,
amrita-shrestha and
PrajwolAmatya
8 tasks
grgprarup
force-pushed
the
bump-ocis-commit-id
branch
from
eca81bd to
f9de9d8
Compare
saw-jan
approved these changes
Nov 24, 2023
grgprarup
force-pushed
the
bump-ocis-commit-id
branch
from
a7d3b56 to
88b0a02
Compare
SwikritiT
approved these changes
Nov 24, 2023
6 tasks
phil-davis
approved these changes
Nov 27, 2023
saw-jan
force-pushed
the
bump-ocis-commit-id
branch
from
4f6a2d7 to
b027f5e
Compare
saw-jan
reviewed
Nov 30, 2023
Comment on lines
+246
to
+248
| if (isRunningWithOCIS() && parameters.shareType === 3 && !parameters.password) { | ||
| return | ||
| } |
There was a problem hiding this comment.
cannot create link share without password in ocis (default behavior)
|
Kudos, SonarCloud Quality Gate passed! |
phil-davis
approved these changes
Dec 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of owncloud/QA#835