Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

Add X-Request-ID to headers unconditionally #1016

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Mar 3, 2022

Add X-Request-ID to headers unconditionally. The version we were requiring already is ages old, doesn't seem relevant anymore. And obviously preventing us to let oCIS announce its correct version, see owncloud/ocis#2918

Removing the version check also meant not needing the semver package
anymore. Removed it from devDependencies, peerDependencies and
documentation accordingly.

Removing a version check also meant not needing the semver package
anymore. Removed it from devDependencies, peerDependencies and
documentation accordingly.
@kulmann kulmann self-assigned this Mar 3, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kulmann kulmann merged commit 506a7e2 into master Mar 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the remove-version-check branch March 3, 2022 21:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants