This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Automatically focus modal when mounted #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
force-pushed
the
feature/modal-focus
branch
from
b454132 to
24fd16c
Compare
LukasHirt
force-pushed
the
feature/modal-focus
branch
from
24fd16c to
51d04d3
Compare
|
focus is the first step, you should also automatically select whatever is inside the field already to make it easy to start typing |
PVince81
reviewed
Jun 2, 2020
| @@ -217,6 +217,12 @@ export default { | |||
| } | |||
| }, | |||
|
|
|||
| mounted() { | |||
| this.$nextTick(() => { | |||
| this.$refs.$_ocModal.focus() | |||
There was a problem hiding this comment.
does this focus on the input field ?
would it also focus on the cancel button if there is no input field ? (if that makes sense)
There was a problem hiding this comment.
Nope, it focuses the modal itself because of accessibility as described in here owncloud/web#2263 (comment)
As soon as the input is focused (both click and keyboard) it already selects the whole value of it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the modal is mounted, it receives automatically a focus. The focus is sent directly to the modal itself so skipping the wrapping div which works only as a background.
Refs owncloud/web#2263