This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Added modal component #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
force-pushed
the
component/modal
branch
from
96933ca to
58d769c
Compare
LukasHirt
commented
Apr 22, 2020
| @@ -17,7 +17,7 @@ | |||
| </template> | |||
|
|
|||
| <script> | |||
| const req = require.context("@/assets/icons/", true, /^\.\/.*\.svg$/) | |||
| const req = require.context("../assets/icons/", true, /^\.\/.*\.svg$/) | |||
There was a problem hiding this comment.
Seems that the require-context-hook plugin is not resolving aliases.
LukasHirt
force-pushed
the
component/modal
branch
3 times, most recently
from
88122c6 to
da74e3b
Compare
LukasHirt
force-pushed
the
component/modal
branch
from
da74e3b to
532787a
Compare
LukasHirt
force-pushed
the
component/modal
branch
from
532787a to
ffd09cc
Compare
|
For now, I put into examples also modal with input to show that we'll be able to use it in that way as well. However, as soon as we get rid of this use case in ocis web app, I'd drop this example not to encourage the devs to follow that path. |
This was referenced Apr 23, 2020
38 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot
Open tasks: