Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Set aria-label on oc-spinner in oc-autocomplete #634

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Set aria-label on oc-spinner in oc-autocomplete #634

merged 1 commit into from
Feb 7, 2020

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Feb 6, 2020

Set missing aria-label on oc-spinner in oc-autocomplete. span got an aria-hidden because for a screenreader it's sufficient to have the label from the spinner, don't need the same text again in the span.

@kulmann kulmann requested a review from PVince81 February 6, 2020 22:36
@kulmann kulmann self-assigned this Feb 6, 2020
PVince81
PVince81 approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always thought I fixed that already but it kept coming back.

You found it ! 👍

@PVince81 PVince81 merged commit a0ad342 into master Feb 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-autocomplete-aria-label branch February 7, 2020 08:57
tboerger pushed a commit that referenced this pull request Feb 7, 2020
commit a0ad342
e5bc94a 
Merge: 6af38c3 2552ae0
Author: Vincent Petry <[email protected]>
Date:   Fri Feb 7 09:57:30 2020 +0100

    Merge pull request #634 from owncloud/fix-autocomplete-aria-label

    Set aria-label on oc-spinner in oc-autocomplete
@kulmann kulmann mentioned this pull request Feb 8, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PVince81 PVince81 PVince81 approved these changes

Assignees

@kulmann kulmann

Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulmann @PVince81