Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

fix: adjust border radius of oc-card vs oc-login-card #2321

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Sep 9, 2022

Description

The border radius of the oc-card class was a little bit too heavy for e.g. drop menus where it's also used. We lowered the border-radius of oc-card to 5px and set the border-radius only for oc-login-card to 15px.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added/updated

@update-docs
Copy link

update-docs bot commented Sep 9, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann force-pushed the border-radius-adjustments branch from 32abb5b to f60341a Compare September 9, 2022 11:15
@kulmann kulmann self-assigned this Sep 9, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lookacat lookacat merged commit 7d7efea into master Sep 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the border-radius-adjustments branch September 9, 2022 11:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants