Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

use single-storey letter a #2299

Merged
merged 5 commits into from
Aug 24, 2022
Merged

use single-storey letter a #2299

merged 5 commits into from
Aug 24, 2022

Conversation

tbsbdr
Copy link
Contributor

@tbsbdr tbsbdr commented Aug 23, 2022

use single storey letter "a"

what does it do?
go to https://rsms.me/inter/lab/?feat-cv11=1 and tick "cv 11 (Single-storey a)" and watch how the small letter "a" changes.

What does it improve?
The rendering of a single storey letter a aligns with our other rounded letters and digits.

Before

Screenshot 000316@2x

After (single storey letter "a")

Screenshot 000315@2x

use single storey letter "a"

what does it do?
go to https://rsms.me/inter/lab/?feat-cv11=1 and tick "cv 11 (Single-storey a)" and watch how the small letter "a" changes.

What does it improve?
The rendering of a single storey letter a aligns with our other rounded letters and digits.
@update-docs
Copy link

update-docs bot commented Aug 23, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@tbsbdr tbsbdr requested review from lookacat and kulmann August 23, 2022 15:41
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I believe this belongs in the font-face definition (see inter.css), but unfortunately that is not supported in browsers other than firefox. -.- Here it works. Not too happy with it, but if it's the only way that works then it's fine.

The linter failed with your PR because the font-feature-settings: "cv11"; is expected before the font-family. Then it should work.

Could you please add the PR link to the changelog item enhancement-use-inter?

Tobias Baader added 4 commits August 24, 2022 13:26
placed "font-feature-settings" before "font-size" to meet order/properties-alphabetical-order
Use single-storey-letter "a" so that the letter "a" is aligned with the "rounded" letters and figures
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kulmann kulmann merged commit 69f5e86 into master Aug 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the use-single-storey-letter-a branch August 24, 2022 12:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants