Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Add HTML title to the resourceName component #2164

Merged
merged 1 commit into from
May 25, 2022
Merged

Conversation

JammingBen
Copy link
Contributor

Description

We've added the HTML title attribute to the resourceName component in case no tooltip is being displayed.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this May 24, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen marked this pull request as ready for review May 24, 2022 11:47
@dschmidt
Copy link
Member

Why is this handled via title instead of computing a value for tooltip in this case as well?

@JammingBen
Copy link
Contributor Author

Why is this handled via title instead of computing a value for tooltip in this case as well?

We don't want our custom tooltip as default because it's very "in your face". Its only purpose is to show additional information if necessary (the path in this case).

The HTML tooltip is way more subtle, hence we decided to use it in case our custom tooltip is not showing. The main use case is when a file name gets truncated because of its length, but the user still wants to know the full name.

@dschmidt
Copy link
Member

Ok, I guess 😁

@JammingBen JammingBen merged commit 6d89aa2 into master May 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the resource-html-title branch May 25, 2022 07:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants