Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Add root file type icon #2158

Merged
merged 1 commit into from
May 31, 2022
Merged

Add root file type icon #2158

merged 1 commit into from
May 31, 2022

Conversation

javfg
Copy link
Contributor

@javfg javfg commented May 23, 2022

This PR adds the file icon for root files.

It would be great if this can be put in the ODS along with the other icons for files from FontAwesome. We've made it so the SVG is very similar to the rest of the file type icons. But if you prefer another approach, please let us know!

@javfg javfg requested a review from pascalwengerter as a code owner May 23, 2022 14:37
@update-docs
Copy link

update-docs bot commented May 23, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann
Copy link
Member

kulmann commented May 23, 2022

Did you create the icon yourself? Can you add a kind of license comment into the svg file?

@javfg
Copy link
Contributor Author

javfg commented May 23, 2022

Did you create the icon yourself? Can you add a kind of license comment into the svg file?

It was created by @elizavetaRa, I just made it black and remove inkscape metadata. I've added a MIT license XML entry. Let me know if that works.

@javfg
Copy link
Contributor Author

javfg commented May 23, 2022

GitHub does not seem to like it, so to be on the safe side I removed the XML and changed it to a simple comment.

@javfg
Copy link
Contributor Author

javfg commented May 24, 2022

Pinging @kulmann. Changes are ready. Thanks for the suggestions!

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please handle the color via src/helpers/resourceIconColorExtensionMapping.json? You'll need to add a new color token to src/tokens/ods/color.yaml for that (end of file, needs correct indentation).
Please also add an author(s) comment to the svg (github handles). Otherwise the license statement is hard to follow.

@javfg
Copy link
Contributor Author

javfg commented May 30, 2022

Please also add an author(s) comment to the svg (github handles). Otherwise the license statement is hard to follow.

@kulmann do you mean adding @elizavetaRa in the Co-authored-by?

The rest of changes are applied too.

Apply suggestions from code review

Co-authored-by: elizavetaRa <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kulmann kulmann merged commit bee3b8e into owncloud:master May 31, 2022
@javfg javfg deleted the add-root-file-icon branch May 31, 2022 11:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants