-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Did you create the icon yourself? Can you add a kind of license comment into the svg file? |
It was created by @elizavetaRa, I just made it black and remove inkscape metadata. I've added a MIT license XML entry. Let me know if that works. |
GitHub does not seem to like it, so to be on the safe side I removed the XML and changed it to a simple comment. |
Pinging @kulmann. Changes are ready. Thanks for the suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please handle the color via src/helpers/resourceIconColorExtensionMapping.json
? You'll need to add a new color token to src/tokens/ods/color.yaml
for that (end of file, needs correct indentation).
Please also add an author(s) comment to the svg (github handles). Otherwise the license statement is hard to follow.
@kulmann do you mean adding @elizavetaRa in the The rest of changes are applied too. |
Apply suggestions from code review Co-authored-by: elizavetaRa <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
This PR adds the file icon for root files.
It would be great if this can be put in the ODS along with the other icons for files from FontAwesome. We've made it so the SVG is very similar to the rest of the file type icons. But if you prefer another approach, please let us know!