This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Redesign FilesTable #1958
Merged
Redesign FilesTable #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kulmann
suggested changes
Feb 17, 2022
There was a problem hiding this comment.
Found some small things.
Regarding the new color variable I'm a bit confused now. I thought that the background-secondary was supposed to be another surface color variable with the color value that was previously given to the highlight color. And that you wanted to come up with a completely new color for the already existing background-highlight color. 🤔 could you resolve my confusion?
lookacat
force-pushed
the
redesign-files-table
branch
from
eade890 to
43258b5
Compare
kulmann
suggested changes
Feb 18, 2022
There was a problem hiding this comment.
- Still not happy with the usage/changes regarding color variables (see detailed comment)
- Sorting icons in table header are only visible on hover in dark mode. In light mode not even on hover. In both modes not permanently for the currently sorted column.
But:
- OcCheckbox looks really good again 🥳
kulmann
approved these changes
Feb 21, 2022
lookacat
force-pushed
the
redesign-files-table
branch
from
eeb4a9e to
6721cb1
Compare
|
Kudos, SonarCloud Quality Gate passed! |
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See owncloud/web#6207
Types of changes
Checklist: