Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Downgrade sass version to avoid deprecation errors from ui-kit #1583

Merged

Conversation

rpocklin
Copy link
Contributor

Description

I'm upgrading our version of owncloud/web to use v9.0.0 of the owncloud-design-system and there are many deprecation warnings in ui-kit, any thoughts on this? Downgrading to sass v1.32.12 removes the warnings and makes it easier to digest the console log and any actual errors that may occur.

⠼ Building Design System...DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.
Recommendation: math.div($global-gutter, 2)
247 │ $card-header-padding-vertical: round($global-gutter / 2) !default;
    │                                      ^^^^^^^^^^^^^^^^^^
    ╵
    node_modules/uikit/src/scss/variables-theme.scss 247:38  @import
    src/styles/styles.scss 187:9                             root stylesheet```

## How Has This Been Tested?
Built with `yarn build:system` and compared binaries, there is no binary difference using Node.js v14.15.0

@update-docs
Copy link

update-docs bot commented Aug 12, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2021

CLA assistant check
All committers have signed the CLA.

@rpocklin rpocklin force-pushed the fix-ui-kit-sass-deprecation-warnings branch from b8bf38b to bfcfc31 Compare August 12, 2021 00:17
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.1% 81.1% Coverage
3.0% 3.0% Duplication

@LukasHirt LukasHirt merged commit d44a1f2 into owncloud:master Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants