Skip to content
This repository was archived by the owner on Jan 3, 2024. It is now read-only.

Fix: Show compile errors and enforce node.js version to permit optional chaining #1579

Merged
merged 3 commits into from
Aug 12, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions build/build-system.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ rm(path.join(config.system.assetsRoot, config.system.assetsSubDirectory), err =>
webpack(webpackConfig, (err, stats) => {
spinner.stop()
if (err) throw err
// process.stdout.write(
// stats.toString({
// colors: true,
// modules: false,
// children: false,
// chunks: false,
// chunkModules: false,
// }) + "\n\n"
// )
process.stdout.write(
stats.toString({
colors: true,
modules: false,
children: false,
chunks: false,
chunkModules: false,
}) + "\n\n"
)

if (stats.hasErrors()) {
console.log(chalk.red(" Design System build failed with errors.\n"))
Expand Down
6 changes: 6 additions & 0 deletions changelog/unreleased/change-build-system-error-improvements
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Change: Show compile errors and enforce node.js version in package.json

Ensure we show compile-time errors on the command line when present and
enforce Node.js v14.0.0 or greater to permit optional chaining to be used

https://github.com/owncloud/owncloud-design-system/pull/1579
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@
"weekstart": "^1.0.0"
},
"engines": {
"node": ">= 8.6.0",
"node": ">= 14.0.0",
"npm": ">= 3.0.0"
}
}