This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Web-648: OcTableFiles enable multiple highlighting using selection #1568
Merged
lookacat
merged 5 commits into
master
from
Web-648-octablefiles-highlight-multiple-files
Aug 6, 2021
Merged
Web-648: OcTableFiles enable multiple highlighting using selection #1568
lookacat
merged 5 commits into
master
from
Web-648-octablefiles-highlight-multiple-files
Aug 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
lookacat
changed the title
WIP: Web-648: OcTableFiles enable multiple highlighting using selection
Web-648: OcTableFiles enable multiple highlighting using selection
Aug 5, 2021
kulmann
suggested changes
Aug 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, didn't expect the changes to be so minimal. Awesome! Added some ideas for improvement.
lookacat
force-pushed
the
Web-648-octablefiles-highlight-multiple-files
branch
from
August 5, 2021 10:32
d8054f5
to
643e7c0
Compare
…s-highlight-multiple-files
As discussed in a call:
|
I would only change the unittests so they work for now since the highlighting logic will changed again soon. |
lookacat
force-pushed
the
Web-648-octablefiles-highlight-multiple-files
branch
2 times, most recently
from
August 6, 2021 07:59
23ec4a7
to
d32915e
Compare
lookacat
force-pushed
the
Web-648-octablefiles-highlight-multiple-files
branch
from
August 6, 2021 08:01
d32915e
to
f7e7d8e
Compare
kulmann
approved these changes
Aug 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Kudos, SonarCloud Quality Gate passed! |
delete-merged-branch
bot
deleted the
Web-648-octablefiles-highlight-multiple-files
branch
August 6, 2021 08:07
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See owncloud/web#5164
Types of changes
Checklist: