Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Web-648: OcTableFiles enable multiple highlighting using selection #1568

Merged
merged 5 commits into from
Aug 6, 2021

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Aug 5, 2021

Description

See owncloud/web#5164

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added/updated

@update-docs
Copy link

update-docs bot commented Aug 5, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat changed the title WIP: Web-648: OcTableFiles enable multiple highlighting using selection Web-648: OcTableFiles enable multiple highlighting using selection Aug 5, 2021
@lookacat lookacat requested a review from kulmann August 5, 2021 09:52
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, didn't expect the changes to be so minimal. Awesome! Added some ideas for improvement.

changelog/unreleased/change-enable-multiple-highlighting Outdated Show resolved Hide resolved
src/components/table/OcTableFiles.vue Outdated Show resolved Hide resolved
@lookacat lookacat force-pushed the Web-648-octablefiles-highlight-multiple-files branch from d8054f5 to 643e7c0 Compare August 5, 2021 10:32
@lookacat lookacat requested a review from kulmann August 5, 2021 10:34
@kulmann
Copy link
Member

kulmann commented Aug 5, 2021

As discussed in a call:

  • the highlight event from OcTable needs to be used to update the selection model. don't emit showDetails anymore.
  • in oC Web we'll watch the selection model to decide whether or not the right sidebar needs to be shown
  • the show details button needs a new implementation: stop the propagation of the click event and add a new method for it, which resets the selection model to the resource id of the clicked row/button (in oC Web this results in a right sidebar for the clicked row)

@lookacat
Copy link
Contributor Author

lookacat commented Aug 5, 2021

I would only change the unittests so they work for now since the highlighting logic will changed again soon.

@lookacat lookacat force-pushed the Web-648-octablefiles-highlight-multiple-files branch 2 times, most recently from 23ec4a7 to d32915e Compare August 6, 2021 07:59
@lookacat lookacat force-pushed the Web-648-octablefiles-highlight-multiple-files branch from d32915e to f7e7d8e Compare August 6, 2021 08:01
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Aug 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

16.7% 16.7% Coverage
0.0% 0.0% Duplication

@lookacat lookacat merged commit 53a77a3 into master Aug 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the Web-648-octablefiles-highlight-multiple-files branch August 6, 2021 08:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants