Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Web-853: Group files and folder when sorting by name #1559

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Web-853: Group files and folder when sorting by name #1559

merged 1 commit into from
Aug 6, 2021

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Aug 3, 2021 •
edited
Loading

Description

See owncloud/web#5613

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests updated
  • Acceptance tests added
  • Documentation added/updated

@pascalwengerter
Copy link
Contributor

@paulcod3 the Fixes #issue-nr in the PR description automatically closes the issue in the web repo once this PR gets merged in the design system. However this is not the case since the ODS needs a release and a version bump merged in the web master before the issue can be considered closed. I usually document this as "Works towards #issue-nr" so it still gets linked within GH but not auto-closed 😉

@lookacat
Copy link
Contributor Author

lookacat commented Aug 3, 2021

@pascalwengerter ah thanks you are right that was the problem last time ^^

@lookacat lookacat changed the title WIP: Web 853 sort folders and files Web 853 sort folders and files Aug 3, 2021
@lookacat lookacat changed the title Web 853 sort folders and files Web-853: Group files and folder when sorting by name Aug 3, 2021
kulmann
kulmann suggested changes Aug 6, 2021
View reviewed changes
@lookacat lookacat force-pushed the WEB-853-sort-folders-and-files branch from 02899a6 to cf20721 Compare August 6, 2021 13:14
@lookacat lookacat requested a review from kulmann August 6, 2021 13:16
@lookacat
Sort folders and files separately
c94306c 
adjusted unittests, added changelog

added PR to changelog

fixed linting

updated changelog title

removed unnecessary check

refactored sortData

fixed eslint
@lookacat lookacat force-pushed the WEB-853-sort-folders-and-files branch from cf20721 to c94306c Compare August 6, 2021 13:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lookacat lookacat merged commit 90f5acf into master Aug 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the WEB-853-sort-folders-and-files branch August 6, 2021 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lookacat @pascalwengerter @kulmann