Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Omit example imgs & docs.scss from prod bundle #1553

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

pascalwengerter
Copy link
Contributor

Description

See changelog items

@pascalwengerter pascalwengerter force-pushed the 02082021_dont-export-example-imgs branch from 604002f to f71aa29 Compare August 2, 2021 13:56
@@ -3,4 +3,34 @@ Change: Remove deprecated components
To focus on the quality of the currently relevant components and to reduce bundle size,
we are dropping a bunch of deprecated components from our design system.

List of removed components, for reference:

- OcActionDrop.spec.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec file doesn't need to be listed

- OcActionDrop.spec.js
- OcActionDrop.vue
- OcAppLayout.vue
- OcAutocomplete.spec.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec file doesn't need to be listed

- OcDisclosureDrop.vue
- OcNav.spec.js
- OcNav.vue
- OcNavItem.spec.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec file doesn't need to be listed

- OcAutocomplete.vue
- OcDatepicker.vue
- OcDisclosureDrop.vue
- OcNav.spec.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec file doesn't need to be listed

- OcNav.vue
- OcNavItem.spec.js
- OcNavItem.vue
- OcNavbar.spec.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec file doesn't need to be listed

- OcNavItem.vue
- OcNavbar.spec.js
- OcNavbar.vue
- OcNavbarItem.spec.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec file doesn't need to be listed

- OcTabbedTab.vue
- OcTabs.vue
- OcTopBar.vue
- OcUser.spec.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec file doesn't need to be listed

@pascalwengerter pascalwengerter force-pushed the 02082021_dont-export-example-imgs branch from f71aa29 to 26ab6d3 Compare August 2, 2021 14:22
@pascalwengerter pascalwengerter requested a review from kulmann August 2, 2021 14:22
@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pascalwengerter pascalwengerter merged commit 9b29a18 into master Aug 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the 02082021_dont-export-example-imgs branch August 2, 2021 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants