Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Added Drag&Drop for OcTable and OcTableFiles #1539

Merged
merged 9 commits into from
Aug 2, 2021
Merged

Added Drag&Drop for OcTable and OcTableFiles #1539

merged 9 commits into from
Aug 2, 2021

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Jul 28, 2021 •
edited
Loading

Description

See owncloud/web#5592

Related Issues

Fixes owncloud/web#5592

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added/updated

@lookacat lookacat requested a review from LukasHirt July 30, 2021 08:34
LukasHirt
LukasHirt approved these changes Jul 30, 2021
View reviewed changes
Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, otherwise awesome!

src/components/table/OcTableFiles.vue Outdated Show resolved Hide resolved
src/components/table/OcTableFiles.vue Outdated Show resolved Hide resolved
@LukasHirt
Copy link
Collaborator

@paulcod3 I've already approved the PR as the mentioned changes are simple to implement and wouldn't require a second review. As soon as you push them, feel free to merge if no one else will request changes

pascalwengerter
pascalwengerter approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@pascalwengerter
Copy link
Contributor

@paulcod3 not sure how much effort you can/want to put into this but testing the drag&drop events could be worth it, esp. with the dragDrop prop and checking whether methods are being called/events being fired in OcTable vs OcTableFiles (see, e.g., https://reactjsnews.com/testing-drag-and-drop-components-in-react-js)

@lookacat
Copy link
Contributor Author

@pascalwengerter yeah i could dig into that if I have basic functionality covered.

@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

18.2% 18.2% Coverage
0.0% 0.0% Duplication

1 similar comment
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

18.2% 18.2% Coverage
0.0% 0.0% Duplication

@lookacat lookacat changed the title WIP: Added Drag&Drop for OcTable and OcTableFiles Added Drag&Drop for OcTable and OcTableFiles Aug 2, 2021
@lookacat lookacat merged commit 201e019 into master Aug 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the WEB-154-move-file-drag-drop branch August 2, 2021 13:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

@pascalwengerter pascalwengerter pascalwengerter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move a single file/folder via drag & drop
3 participants
@lookacat @LukasHirt @pascalwengerter