Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

feat: improve switch UI and a11y #1421

Merged
merged 4 commits into from
Jun 25, 2021
Merged

feat: improve switch UI and a11y #1421

merged 4 commits into from
Jun 25, 2021

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Jun 24, 2021 •
edited
Loading

Description

  • Refactor switch component
  • Move styles directly to SFC
  • Add unit tests
  • Round corners
  • Add label
  • Use button

Screenshots

image

Open tasks:

  • unit tests

@LukasHirt LukasHirt self-assigned this Jun 24, 2021
@LukasHirt LukasHirt marked this pull request as ready for review June 24, 2021 11:56
@LukasHirt LukasHirt requested a review from kulmann June 24, 2021 11:56
@LukasHirt LukasHirt requested a review from kulmann June 25, 2021 08:59
@sonarcloud
Copy link

sonarcloud bot commented Jun 25, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kulmann kulmann merged commit 80f5753 into master Jun 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the feat/improve-switch-ui branch June 25, 2021 09:14
This was referenced Jul 28, 2021
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees

@LukasHirt LukasHirt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasHirt @kulmann