Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

WIP for #1289: Use OcSelect component for OcAutocomplete internally #1301

Conversation

paulneubauer
Copy link

Basic implementation has been done, still some points have to be added to complete issue 1289.

  • Styling should be refactored because the dom hierarchy changed due using oc-select
  • During delayed fetch loading spinner should be added again
  • There are also changes made in the Oc-Select, so the last sample example implementation should be updated (using filter)
  • It should be checked if aria is still implemented the right way (vue-select uses it as far as I know but still should be checked)

Thats all. Thanks for the challenge I really liked it :)

@update-docs
Copy link

update-docs bot commented May 17, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pascalwengerter pascalwengerter changed the title WIP for 1289: Use OcSelect component for OcAutocomplete interenally WIP for 1289: Use OcSelect component for OcAutocomplete internally May 20, 2021
@dschmidt dschmidt changed the title WIP for 1289: Use OcSelect component for OcAutocomplete internally WIP for #1289: Use OcSelect component for OcAutocomplete internally Jun 30, 2021
@dschmidt
Copy link
Member

The issue is mentioned in the title but not actually linked: #1289

@kulmann
Copy link
Contributor

kulmann commented Jul 22, 2021

Superseded by #1521

@kulmann kulmann closed this Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants