This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Position dropzone #1002
Merged
Position dropzone #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rientates by the viewport which means it always coveres the entire screen. This is something we could't know and the decision should be left to the consuming app. instead we use position absolute to just cover the next parent which ist positioned relative or the viewport. in situations where the body is higher or wider then the viewport fixed works better because absolute won't cover the scrollable parts of the content. since oc apps always do scrolling on their own this is no problem
fix changelog typos
LukasHirt
reviewed
Dec 14, 2020
phil-davis
reviewed
Dec 14, 2020
LukasHirt
approved these changes
Dec 14, 2020
|
@fschade Why was this closed? |
ugh, i don't know. reopened and merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
together with
owncloud/web#4489
it fixes
owncloud/ocis#1052