Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not spam log file when running in parallel with oauth app + RELASE 2.3.1 ... #319

Merged
merged 3 commits into from
Oct 18, 2024
Merged

fix: do not spam log file when running in parallel with oauth app + RELASE 2.3.1 ... #319

merged 3 commits into from
Oct 18, 2024

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Sep 2, 2024 •
edited
Loading

Description

as title says ....

Related Issue

Motivation and Context

How Has This Been Tested?

  • 🧠

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@DeepDiver1975 DeepDiver1975 force-pushed the fix/handle-non-jwt-token branch from a315339 to e5d599f Compare September 2, 2024 12:34
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@DeepDiver1975
Copy link
Member Author

this has to wait until @jnweiger is back for QA ....

@jnweiger
Copy link
Contributor

jnweiger commented Oct 16, 2024 •
edited
Loading

Test setup

  • oidc with keycloak, + oauth2.
  • play aound with simultaneous logins via keycloak, desktop client, local web users.
  • grep 'could not be fetched' owncloud.log returns nothing. GOOD.

@jnweiger jnweiger mentioned this pull request Oct 18, 2024
Closed
43 tasks
@jnweiger
Copy link
Contributor

Closes #327

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@DeepDiver1975 DeepDiver1975 changed the title fix: do not spam log file when running in parallel with oauth app fix: do not spam log file when running in parallel with oauth app + RELASE 2.3.1 ... Oct 18, 2024
@DeepDiver1975
Copy link
Member Author

includes release 2.3.1 because people are lazy ....

@DeepDiver1975 DeepDiver1975 merged commit 0ad9161 into master Oct 18, 2024
3 checks passed
@DeepDiver1975 DeepDiver1975 deleted the fix/handle-non-jwt-token branch October 18, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IljaN IljaN IljaN approved these changes

Assignees

@jnweiger jnweiger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DeepDiver1975 @jnweiger @IljaN