-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config option to allow basic auth only for guests #253
Conversation
Guests will be able to access ownCloud using basic auth, but other users will need to access through other mechanisms such as oidc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- testable via unit test ?
- 🤖 is 🔴
lib/LoginChecker.php
Outdated
* @throws LoginException if the uid isn't a guest | ||
*/ | ||
public function ensurePasswordLoginJustForGuest($loginType, $uid) { | ||
if (!$this->config->getSystemValue('openid-connect.basic_auth_guest_only', false)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe only add the listener if config states ...... but minor detail .....
Kudos, SonarCloud Quality Gate passed! |
Needs documentation @mmattel -> owncloud/docs-server#665 |
indeed - until today we don't have any translations .... I can take care |
Guests will be able to access ownCloud using basic auth, but other users will need to access through other mechanisms such as oidc.
Description
The new
openid-connect.basic_auth_guest_only
config option only allows guests to be able to log in using basic auth. Other users will need to use another auth mechanisms (such as oidc)Note that the users can still log in with ANY OTHER auth mechanism available, not just oidc. It's expected that oidc is the only alternative though.
NOTE: minimum OC version raised to 10.4 in order to use the
UserTypeHelper
to detect guest users.To be checked:
Related Issue
https://github.com/owncloud/enterprise/issues/5295
Motivation and Context
How Has This Been Tested?
Manually tested:
'openid-connect.basic_auth_guest_only' => true
in the config.php fileNote: Users (except guests) MUST also use a different auth mechanism (such as oidc) in order to access to the webdav interface. This might affect mobile and desktop clients. It's expected to work, but not tested yet.
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: