-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] enhancement: handle ocm event notifications #9966
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
@micbar what about our other services (activitylog, audit, ...), should i add the new event there too? |
Yes, that would be awesome! |
4213981
to
bd6b6da
Compare
@fschade Pls check if the audit services also contains translation relevant end user strings (not log stuff). In case, you need to have a look at https://owncloud.dev/services/general-info/add-translations/ for a how to. This includes the translation setup and the readme addition. Pls also have a look at the admin docs Email Notification Templates respectively in the corresponding notification readme if we are missing anything regarding email templating |
… in the audit service
Co-authored-by: Martin <[email protected]>
83b328b
to
9479a46
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
[full-ci] enhancement: handle ocm event notifications
Description
By now, the sciencemesh part in reva was responsible to notify the invitee that a invitaion happened, in ocis we have a event driven approach.
This PR introduces that and handles those invitation events in the notification service by sending mails.
Related Issue
How Has This Been Tested?
Types of changes
Checklist: