Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use bool type for web embed delegatedAuthentication #9692

Merged
merged 1 commit into from
Jul 30, 2024
Merged

use bool type for web embed delegatedAuthentication #9692

merged 1 commit into from
Jul 30, 2024

Conversation

butonic
Copy link
Member

@butonic butonic commented Jul 25, 2024

when trying the next branch of the ocis charts and

      - services:
          web:
            config:
              embed:
                delegateAuthentication: "true"

the web ui would choke on the string because it was expecting to get a bool.

@butonic butonic requested a review from kulmann as a code owner July 25, 2024 14:45
@butonic butonic removed the request for review from kulmann July 25, 2024 14:45
@butonic butonic mentioned this pull request Jul 25, 2024
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@butonic butonic requested a review from kulmann July 26, 2024 13:19
@butonic butonic self-assigned this Jul 26, 2024
@butonic butonic merged commit f5af53e into master Jul 30, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Jul 30, 2024
@butonic
Merge pull request #9692 from owncloud/fix-web-delegatedauthenticatio…
cefd041 
…n-type

use bool type for web embed delegatedAuthentication
@ScharfViktor ScharfViktor mentioned this pull request Aug 20, 2024
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees

@butonic butonic

Labels
Type:Bug
Projects
Infinite Scale Team Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@butonic @AlexAndBear