Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isolated app configuration #9691

Merged
merged 2 commits into from
Aug 6, 2024
Merged

isolated app configuration #9691

merged 2 commits into from
Aug 6, 2024

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Jul 25, 2024

Description

Introduce a new feature which allows configuring applications individually instead of using the global apps.yaml file.
With that, each application can have its own configuration file, which will be loaded by the WEB service.

The local configuration has the highest priority and will override the global configuration.
The Following order of precedence is used: local.config > global.config > manifest.config.

Besides the configuration, the application now be disabled by setting the disabled field to true in one of the configuration files.

APP/manifest.json

{
  "entrypoint": "index.js",
  "config": {
    "from_manifest": 1,
    "bar": 1
  }
}

apps.yaml

bar:
  config:
    from_global: 1
    bar: 2

APP/config.json

{
  "config": {
    "from_local": 1,
    "bar": 3
  }
}

result https://XZY/config.json

{
  "external_apps": [
    {
      "id": "bar",
      "path": "/assets/apps/bar/index.js",
      "config": {
        "bar": 3,
        "from_global": 1,
        "from_local": 1,
        "from_manifest": 1
      }
    }
  ]
}

Related Issue

Motivation and Context

Allow to configure application individually.

How Has This Been Tested?

  • unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@fschade fschade requested a review from kulmann as a code owner July 25, 2024 14:05
Release Notes
=============

Testing Notes
=============

Deploy Notes
============

Technical Change Notes
======================
@fschade fschade changed the title Commit Title (50 char max) isolated app configuration Jul 25, 2024
services/web/README.md Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Aug 2, 2024

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 😍

@fschade fschade merged commit 598786a into owncloud:master Aug 6, 2024
3 checks passed
ownclouders pushed a commit that referenced this pull request Aug 6, 2024
@ScharfViktor ScharfViktor mentioned this pull request Aug 20, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App manifest.json overwrites my app config
3 participants