-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include additional metadata for tracing the collaboration service #9684
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
993afe2
to
9e0cdaa
Compare
9e0cdaa
to
083a2e1
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
feat: include additional metadata for tracing the collaboration service
Description
Improve tracing of the collaboration service. This includes:
It might be better if the
X-WOPI-Override
header was part of the span name, but it seems we'd need to replace the otelchi middleware with our custom version. For now, the header is included as span attribute.Related Issue
no open issue
Motivation and Context
This should reflect better how much time is spent in other services, specially since the upload and download times weren't being shown before.
How Has This Been Tested?
Manually checked with a jaeger instance.
Screenshots (if appropriate):
Types of changes
Checklist:
Additional things to consider
X-WOPI-Override
header in the span name might be ideal. However, there is no good way to do it.