bump go-cs3apis and reva to latest master #9587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Also includes a reva bump Closes: owncloud#9554
reva tries to avoid copying proto messages now. This changed some calls to take pointers now (mainly e.g. FormatResourceId())
The prototext formater (used by '.String()') inserts spaces randomly (see: https://protobuf.dev/reference/go/faq/#unstable-text).
mainly "copylocks: return copies lock value" related things
|
Grmbl. Not sure what to do with the Sonarcloud complaints. It's basically all about the 'copylocks' issue that is raised now when copying proto message structs. I tried to address a few of them, but new ones keep popping up. I somehow think we should ignore them in this PR. And provide a followup PR that addresses all of them. |
|
2403905
approved these changes
Jul 11, 2024
micbar
approved these changes
Jul 11, 2024
ownclouders
pushed a commit
that referenced
this pull request
Jul 11, 2024
bump go-cs3apis and reva to latest master
ownclouders
pushed a commit
that referenced
this pull request
Jul 12, 2024
bump go-cs3apis and reva to latest master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.