Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: polish secure view #9532

Merged
merged 5 commits into from
Jul 5, 2024
Merged

fix: polish secure view #9532

merged 5 commits into from
Jul 5, 2024

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Jul 4, 2024

Description

Polish Secure view

  1. Fix view_comment mode for pdfs - needed for Secure Viewable PDF files
  2. Remove the secure viewer role from space roots.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@micbar micbar requested review from jvillafanez, kobergj and fschade July 4, 2024 11:27
@micbar micbar self-assigned this Jul 4, 2024
@micbar micbar force-pushed the polish-secure-view branch from ac3cf23 to 7860cb8 Compare July 4, 2024 15:14
@micbar micbar requested a review from jvillafanez July 4, 2024 15:15
@micbar micbar requested a review from 2403905 July 4, 2024 16:11
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Bugs (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

jvillafanez
jvillafanez approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@jvillafanez jvillafanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go with this for now. I'll try to cleanup the service file at some point.

@micbar micbar merged commit 3ea77d2 into master Jul 5, 2024
3 of 4 checks passed
@micbar micbar deleted the polish-secure-view branch July 5, 2024 07:24
ownclouders pushed a commit that referenced this pull request Jul 5, 2024
@micbar
Merge pull request #9532 from owncloud/polish-secure-view
d551a5a 
fix: polish secure view
@micbar micbar mentioned this pull request Jul 8, 2024
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvillafanez jvillafanez jvillafanez approved these changes

@kobergj kobergj Awaiting requested review from kobergj kobergj is a code owner

@fschade fschade Awaiting requested review from fschade

@wkloucek wkloucek Awaiting requested review from wkloucek

@phil-davis phil-davis Awaiting requested review from phil-davis phil-davis is a code owner

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@2403905 2403905 Awaiting requested review from 2403905

Assignees

@micbar micbar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ocis][web] polish secure view
2 participants
@micbar @jvillafanez