Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sharing-ng): permission listings for personal and virtual drive items #9438

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix(sharing-ng): permission listings for personal and virtual drive items #9438

merged 1 commit into from
Jun 24, 2024

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Jun 21, 2024

Description

This PR fixes an issue where the sharing-ng service was not able to list permissions for personal and virtual drive items.

Related Issue

How Has This Been Tested?

  • acceptance tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@fschade fschade added Type:Bug Status:Needs-Review Needs review from a maintainer Priority:p2-high Escalation, on top of current planning, release blocker labels Jun 21, 2024
@fschade fschade self-assigned this Jun 21, 2024
@fschade fschade requested review from nirajacharya2 and micbar June 21, 2024 12:01
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
12.0% Duplication on New Code

See analysis details on SonarCloud

@nirajacharya2
Copy link
Contributor

Feature files lgtm 👍

kobergj
kobergj approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fschade fschade merged commit 77c4f72 into owncloud:master Jun 24, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Jun 24, 2024
@fschade
Merge pull request #9438 from fschade/fix-sharingng-permission-listings
3b1ceae 
fix(sharing-ng): permission listings for personal and virtual drive items
@micbar micbar mentioned this pull request Jul 8, 2024
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@micbar micbar Awaiting requested review from micbar

Assignees

@fschade fschade

Labels
Priority:p2-high Escalation, on top of current planning, release blocker Status:Needs-Review Needs review from a maintainer Type:Bug
Projects
None yet
Milestone
No milestone
3 participants
@fschade @nirajacharya2 @kobergj