-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K6 Testing #941
K6 Testing #941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 yesssss thanks for the TS, long time no work with it <3.
"plugins": [ | ||
"lodash", | ||
"@babel/proposal-class-properties", | ||
"@babel/proposal-object-rest-spread" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this plugin even if we're not explicitly using the spread operator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not right now, but soon we will... for example
http.puthttps://foo.bar", {headers: {...defaultHeaders(), foo: 'bar'}})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exactly, spread is a handy one 👍
test/k6/rollup.config.js
Outdated
import multiInput from 'rollup-plugin-multi-input'; | ||
import path from 'path'; | ||
|
||
const extensions = ['.js', '.jsx', '.ts', '.tsx'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jsx
and tsx
leftover from some react? I think we won't have view files here, orrrr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea its a left over, it can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also integrate in to Makefile? (if possible)
👍
yea, sure... but first i need to get this landed as a base. later it gets an real integration |
@fschade you might want to add a changelog |
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
@@ -0,0 +1,22 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has a space at the beginning of the file name?
Was that intended?
What do we do about Codacy results on this sort of stuff? Merge anyway? Add it to an exclusion list? Adjust the formatting etc to make Codacy happy? |
Author: Florian Schade <[email protected]> Date: Tue Nov 24 18:39:27 2020 +0100 K6 Testing (#941) * first k6 tests
add k6 as load tester