-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-only] Create new 'ocis_wopi_community' deployment example #9394
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Quality Gate passedIssues Measures |
I tested it and it works to me.
How? If you deleted |
I want to streamline the wopi example. |
@mmattel Please coordinate before starting such a large refactoring. I do not want the wopi and community example to diverge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let us discuss if we need a new one or can pimp the existing one.
This gets usually configured when using Letsencrypt with an own domain. Upcoming admin docs have a note in it and I took your note and added this to the main comment on top. |
@micbar I like the idea of having a shrunken down wopi example without onlyoffice, inbucket and companion. I suggest just adding the |
Please adapt the existing ocis_wopi example to make that possible. We need the modularity. Please also adapt the .env files in the other examples. |
Closing, superseded by #9412 |
Fixes: #9388 (New community ready deployment example using WOPI necessary)
This PR adds a new deployment example that focuses on community use. It derives from the
ocis_wopi
example and contains the following changes:Note that the latest version 24.x is not working as it cant update a file but you need to create a copy.
.env
file has been updated accordingly and readability improvedcompose
file has been updated accordingly and readability improved (only minor changes)REVA_GATEWAY
have been removed as they were no longer available and therefore senseless.Comments:
ocis_wopi
6.1GB --> 2.7GB.latest
. Redirection to login hangs.Tests:
*.owncloud.test
domain (self signed certificates)Imho, a double test check should be made @ScharfViktor
Backport to
stable-5.0
necessary.@tbsbdr @micbar