Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-only] Create new 'ocis_wopi_community' deployment example #9394

Closed
wants to merge 1 commit into from

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Jun 17, 2024

Fixes: #9388 (New community ready deployment example using WOPI necessary)

This PR adds a new deployment example that focuses on community use. It derives from the ocis_wopi example and contains the following changes:

  • Removal of the following containers and their configuration:
    • Inbucket
    • Companion
    • Onlyoffice
  • Removal of:
    • Supplemental monitoring
  • Updating the following containers:
    • traefik: 2.9.1 --> 3.0.2
    • collabora: 23.05.5.2.1 --> 23.05.10.1.1
      Note that the latest version 24.x is not working as it cant update a file but you need to create a copy.
    • wopiserver: 10.4.0 --> 10.5.0
  • Adding the possibility to configure ocis notifications (email)
  • The .env file has been updated accordingly and readability improved
  • The compose file has been updated accordingly and readability improved (only minor changes)
    • Note that "dead" envvars from the original example like REVA_GATEWAY have been removed as they were no longer available and therefore senseless.

Comments:

  • This example is now much smaller compared to ocis_wopi 6.1GB --> 2.7GB.
  • Only a few changes necessary in the prepared admin docs currently visible on staging (just working on it).
  • This example is only compatible with ocis v5.0.5 but not with latest. Redirection to login hangs.

Tests:

  • Locally tested successfully using the *.owncloud.test domain (self signed certificates)
  • A test using an own domain with Letsencrypt and SMTP settings is open

Imho, a double test check should be made @ScharfViktor

Backport to stable-5.0 necessary.

@tbsbdr @micbar

@mmattel mmattel added the Topic:Docker Issues related to our official Docker containers label Jun 17, 2024
@mmattel mmattel requested review from dragonchaser and kobergj June 17, 2024 11:51
Copy link

update-docs bot commented Jun 17, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@mmattel mmattel changed the title Create new 'ocis_wopi_community' deployment example [docs-only] Create new 'ocis_wopi_community' deployment example Jun 17, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ScharfViktor
Copy link
Contributor

I tested it and it works to me.

Adding the possibility to configure ocis notifications (email)

How? If you deleted Inbucket?

@micbar
Copy link
Contributor

micbar commented Jun 17, 2024

I want to streamline the wopi example.

@micbar
Copy link
Contributor

micbar commented Jun 17, 2024

@mmattel Please coordinate before starting such a large refactoring.

I do not want the wopi and community example to diverge.

Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let us discuss if we need a new one or can pimp the existing one.

@mmattel
Copy link
Contributor Author

mmattel commented Jun 17, 2024

How? If you deleted Inbucket?

This gets usually configured when using Letsencrypt with an own domain. Upcoming admin docs have a note in it and I took your note and added this to the main comment on top.

@dragonchaser
Copy link
Contributor

@micbar I like the idea of having a shrunken down wopi example without onlyoffice, inbucket and companion. I suggest just adding the docker-compose.yaml from this PR to the ocis-wopi example in the deployments directory as docker-compose-collabora-only.yaml and let the users pick the suiting one using docker-compose -f. This would give us this example and does not force us to maintain two full-blown examples.

@micbar
Copy link
Contributor

micbar commented Jun 18, 2024

Please adapt the existing ocis_wopi example to make that possible. We need the modularity.

Please also adapt the .env files in the other examples.

@mmattel
Copy link
Contributor Author

mmattel commented Jun 19, 2024

Closing, superseded by #9412

@mmattel mmattel closed this Jun 19, 2024
@mmattel mmattel deleted the add_ocis_wopi_community branch June 19, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic:Docker Issues related to our official Docker containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New community ready deployment example using WOPI necessary
4 participants