Activity API

[kobergj]

Adds an API to retrieve activities

Fixes #9196

[micbar]

Question: Do we use the generated libregraph types?

[kobergj]

No. We are barely using them. No need to use created ones imho.

[micbar]

I think we have a problem. This api endpoint needs to work with our generated clients. Is the spec already added to libregraph?

[kobergj]

Yes. Then we really have a problem. We need to discuss this.

[micbar]

What needs to be discussed?

We are using libregraph. So our normal workflow is to create the spec and then the implementation.

Why should it be different here?

[kobergj]

Well the only thing we have in common with the graph spec is the url. We are returning a different response and expect a different request. That is because we are misusing the endpoint as it doesn't exist as we need it to be.

[2403905]

Shouldn't we add a mutex to the ActivitylogService structure?
We are consuming and writing the events in Run() and at the same time we are doing threads unsafe read write sequence in a RemoveActivities

[kobergj]

Yes you are right. But adding a mutex wont fix the problem. In a distributed environment there might be multiple activitylog services running 🤔 I'll add a mutex for now, but we need a better solution.

[2403905]

Now it is deadlock
You locked for the r/w a.lock.Lock() in RemoveActivities and after that try to a.lock.RLock() in Activities with waits forever

[2403905]

The proper solution could be to split the Activities method and use the private in case if we have to read write

func (a *ActivitylogService) Activities(rid *provider.ResourceId) ([]RawActivity, error) {
       	a.lock.RLock()
	defer a.lock.RUnlock()
        return s.activities(rid)
}

func (a *ActivitylogService) activities(rid *provider.ResourceId) ([]RawActivity, error) {
	resourceID := storagespace.FormatResourceID(*rid)

        records, err := a.store.Read(resourceID)
        if err != nil && err != microstore.ErrNotFound {
		return nil, fmt.Errorf("could not read activities: %w", err)
	}

	if len(records) == 0 {
		return []RawActivity{}, nil
	}

	var activities []RawActivity
	if err := json.Unmarshal(records[0].Value, &activities); err != nil {
		return nil, fmt.Errorf("could not unmarshal activities: %w", err)
	}

	return activities, nil
}

[2403905]

Looks good for me

[2403905]

Now it is deadlock
You locked for the r/w a.lock.Lock() in RemoveActivities and after that try to a.lock.RLock() in Activities with waits forever

[mmattel]

@kobergj mind to fix a typo from your former ActivityLog PR that would fit in here:
ACTIVITYLOG_STORE_SIZE: though not exclicitly set as default --> though not explicitly set as default
(the missing p in exclicitly...)

[kobergj]

Only rebased to master - no code changes

[2403905]

It is a nitpick but could we use mu sync.RWMutex which is the de facto standard?
Nevermind

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
40.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud