Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change image library and refactor thumbnails service #910

Merged
merged 1 commit into from
Nov 26, 2020
Merged

change image library and refactor thumbnails service #910

merged 1 commit into from
Nov 26, 2020

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Nov 20, 2020

The library went out out support.
Also did some refactoring of the thumbnails service code.

@C0rby C0rby requested review from butonic, kulmann and refs November 20, 2020 09:24
@C0rby C0rby self-assigned this Nov 20, 2020
@C0rby C0rby force-pushed the thumbnails-rewrite branch from 76dca93 to fa8cdd6 Compare November 20, 2020 09:26
kulmann
kulmann requested changes Nov 26, 2020
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultra nit pick in the changelog item 😁 Code looks good! 🚀

changelog/unreleased/change-thumbnails-library.md Outdated
@@ -0,0 +1,6 @@
Change: replace the library which scales the images

The library went out out support.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo. you probably meant out of

@kulmann
Copy link
Member

kulmann commented Nov 26, 2020

Needs a rebase

@C0rby C0rby force-pushed the thumbnails-rewrite branch from fa8cdd6 to c46a559 Compare November 26, 2020 15:37
kulmann
kulmann approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@C0rby C0rby merged commit 0798f40 into master Nov 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the thumbnails-rewrite branch November 26, 2020 16:55
ownclouders pushed a commit that referenced this pull request Nov 26, 2020
@C0rby
commit 0798f40
20b15b6 
Merge: dbb52f2 c46a559
Author: David Christofas <[email protected]>
Date:   Thu Nov 26 17:55:07 2020 +0100

    Merge pull request #910 from owncloud/thumbnails-rewrite

    change image library and refactor thumbnails service
@micbar micbar mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@butonic butonic butonic approved these changes

@refs refs Awaiting requested review from refs

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@C0rby @kulmann @butonic