Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accounts list scroll #909

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Fix accounts list scroll #909

merged 2 commits into from
Nov 20, 2020

Conversation

LukasHirt
Copy link
Collaborator

No description provided.

@LukasHirt LukasHirt requested a review from kulmann November 20, 2020 09:04
@LukasHirt LukasHirt self-assigned this Nov 20, 2020
kulmann
kulmann requested changes Nov 20, 2020
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like you said, assets need to be re-generated. Also, I noticed that - at least for me - the accounts list doesn't show scrollbars on scrolling.

@LukasHirt
Copy link
Collaborator Author

Also, I noticed that - at least for me - the accounts list doesn't show scrollbars on scrolling.

Odd. I see it nicely.

image

@kulmann
Copy link
Member

kulmann commented Nov 20, 2020

Also, I noticed that - at least for me - the accounts list doesn't show scrollbars on scrolling.

Odd. I see it nicely.

Weird. Now I have the scrollbar as well...
Anyway, assets are updated.

kulmann
kulmann approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@LukasHirt LukasHirt merged commit 4bf0faf into master Nov 20, 2020
@LukasHirt LukasHirt deleted the fix-accounts-scroll branch November 20, 2020 11:28
ownclouders pushed a commit that referenced this pull request Nov 20, 2020
commit 4bf0faf
ea79ad7 
Merge: 0ea04c0 40449ac
Author: Lukas Hirt <[email protected]>
Date:   Fri Nov 20 12:28:47 2020 +0100

    Merge pull request #909 from owncloud/fix-accounts-scroll
@micbar micbar mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees

@LukasHirt LukasHirt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasHirt @kulmann