-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci] adding test for listing permission of shares drive #8904
Conversation
491fa40
to
c437fd9
Compare
Quality Gate passedIssues Measures |
When user "Alice" lists the permissions of space "Shares" using the Graph API | ||
Then the HTTP status code should be "200" | ||
And the JSON data of the response should match | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ScharfViktor we have two APIs for listing permission for drives i.e.:
- https://owncloud.dev/libre-graph-api/#/drives.root/ListPermissionsSpaceRoot
- https://owncloud.dev/libre-graph-api/#/drives.permissions/ListPermissions
imo those API should should give same output but. when listing permission of shares space
we get different response
-
when using
/root
endpoint
ocis/tests/acceptance/features/apiSharingNg/listPermissions.feature
Lines 1044 to 1045 in 13ee2d9
When user "Alice" tries to list the permissions of space "<drive>" using root endpoint of the Graph API Then the HTTP status code should be "400" -
when using
/drives/{drivrId}/items/{itemid}
:200
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need clarification/confirmation
CC @rhafer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made an issue regarding this #8922
When user "Alice" lists the permissions of space "Shares" using the Graph API | ||
Then the HTTP status code should be "200" | ||
And the JSON data of the response should match | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need clarification/confirmation
CC @rhafer
|
c437fd9
to
81dcde4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first I thought it was a duplicate https://github.com/owncloud/ocis/pull/9438/files#diff-77314df4d252124f66502910bdfc4343a87d01f39299398d45182c1d1ca5caedR1363-R1384
then I saw that it's different endpoint. Maybe it makes scence to split feature file?
81dcde4
to
11aed1c
Compare
yeah, we have to organize the scenarios to differentiate between root and permissions endpoints. but in next PR |
11aed1c
to
36e6a67
Compare
36e6a67
to
f30f18e
Compare
Quality Gate passedIssues Measures |
[tests-only][full-ci] adding test for listing permission of shares drive
Description
this pr adds test for listing permissions of shares drive
added scenarios
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: