-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci]Add tests for listing drive root permission #8824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 10, 2024
amrita-shrestha
force-pushed
the
add-tests-for-list-permission-for-drives
branch
from
April 11, 2024 04:13
e64e3aa
to
8c3819b
Compare
amrita-shrestha
requested review from
saw-jan,
nirajacharya2,
SagarGi,
grgprarup,
PrajwolAmatya and
nabim777
April 11, 2024 04:51
amrita-shrestha
force-pushed
the
add-tests-for-list-permission-for-drives
branch
2 times, most recently
from
April 11, 2024 05:33
f6e1a7c
to
f1deeba
Compare
SagarGi
reviewed
Apr 15, 2024
amrita-shrestha
force-pushed
the
add-tests-for-list-permission-for-drives
branch
from
April 15, 2024 05:11
f1deeba
to
6de8520
Compare
SagarGi
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
saw-jan
requested changes
Apr 15, 2024
amrita-shrestha
force-pushed
the
add-tests-for-list-permission-for-drives
branch
from
April 17, 2024 09:08
6de8520
to
4a58fcf
Compare
saw-jan
reviewed
Apr 17, 2024
amrita-shrestha
force-pushed
the
add-tests-for-list-permission-for-drives
branch
2 times, most recently
from
April 18, 2024 03:31
0b2abc1
to
d945c32
Compare
saw-jan
reviewed
Apr 18, 2024
saw-jan
reviewed
Apr 18, 2024
amrita-shrestha
force-pushed
the
add-tests-for-list-permission-for-drives
branch
from
April 18, 2024 08:52
d945c32
to
71c6276
Compare
saw-jan
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Quality Gate passedIssues Measures |
delete-merged-branch
bot
deleted the
add-tests-for-list-permission-for-drives
branch
April 18, 2024 09:32
ownclouders
pushed a commit
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has added tests for listing permission using
/drives/{driveID}/root/permissions
api endpoint.Related Issue
/graph/v1beta1/drives/{driveId}/root
endpoint #8810 [Sharing NG] getting permissions for drive via driveId doesn't work #8351Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: