Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-5.0] chore: adjust env vars so that check-env-var-annotations passes #8583

Merged
merged 37 commits into from
Mar 7, 2024
Merged

[stable-5.0] chore: adjust env vars so that check-env-var-annotations passes #8583

merged 37 commits into from
Mar 7, 2024

Conversation

phil-davis
Copy link
Contributor

Backport #8574 to stable-5.0

@owncloud owncloud deleted a comment from update-docs bot Mar 6, 2024
@mmattel mmattel mentioned this pull request Mar 6, 2024
Merged
@mmattel
Copy link
Contributor

mmattel commented Mar 6, 2024 •
edited
Loading

@phil-davis
Dont we want to add, as commented in the master branch, the corresponding PR's to this backport to make a one shot backport? These PR's are all about the envvars added table. Note, sequence to add is important, oldest first...

#8577 ([docs-only] Fix added envars table) and
#8582 ([docs-only] And more envvars that are added to the table)
new:
#8588 ([docs-only] More updates to the added envvar tables)
#8590 ([docs-only] Finally fixed the added tables, 2 envvars were accidentially deleted)

Note that I needed to solve a conflict in the master branch post merging #8588, see this commit for details. I am sure that this needs to be fixed here too...

@phil-davis
Copy link
Contributor Author

The backport of #8586 needs to be done and merged into stable-5.0
Then I will rebase this and add the various things that @mmattel has mentioned above.
Some time early tomorrow, hopefully.

@phil-davis phil-davis force-pushed the backport/env-var-introductionVersion branch from 58b78c1 to db2079a Compare March 6, 2024 23:54
phil-davis and others added 18 commits March 7, 2024 13:51
@phil-davis
chore: adjust doc of check-env-var-annotations
df489d6
@phil-davis
chore: display line numbers in output of check-env-var-annotations
b1e9ab9
@phil-davis
chore: adjust logic for annotation checks
3ab6d9e
@phil-davis
chore: add introductionVersion pre5.0 to environment variable docs
d27e33a
@phil-davis
chore: add missing descriptions to env vars
4b87667
@phil-davis @dragonchaser
chore: adjust env var descriptions
44e1d0a 
Co-authored-by: Christian Richter <[email protected]>
@phil-davis
chore: add check-env-var-annotations to drone CI
2d06eef
@phil-davis @dragonchaser
Add STORAGE_USERS_MACHINE_AUTH_API_KEY
3f0f09d 
which was accidentally missing, introduced in 5.0

Co-authored-by: Christian Richter <[email protected]>
@phil-davis
chore: move tracing env vars into auth-service/pkg/config/tracing.go …
ec2c6f7 
…section
@phil-davis
chore: set introductionVersion 5.0 in shared_types.go
a3d533a
@phil-davis
chore: set introductionVersion 5.0 in antivirus audit audit-service
f600fa8
@phil-davis
chore: set introductionVersion 5.0 in services/clientlog
a23a6bd
@phil-davis
chore: set introductionVersion 5.0 in services/eventhistory
2aaf0f8
@phil-davis
chore: set introductionVersion 5.0 in services/frontend
c1fe08e
@phil-davis
chore: set introductionVersion 5.0 in services/gateway
b5a9b1a
@phil-davis
chore: set introductionVersion 5.0 in services/graph
22c1947
@phil-davis
chore: set introductionVersion 5.0 in services/notifications and ocdav
b9d3a3a
@phil-davis
chore: set introductionVersion 5.0 in services/ocm
b2714f3
phil-davis and others added 19 commits March 7, 2024 13:51
@phil-davis
chore: set introductionVersion 5.0 in services/policies
11f248f
@phil-davis
chore: set introductionVersion 5.0 in services/ocs
b1cb0f6
@phil-davis
chore: set introductionVersion 5.0 in services/postprocessing
090d1f5
@phil-davis
chore: set introductionVersion 5.0 in services/proxy
4ec1a00
@phil-davis
chore: set introductionVersion 5.0 in services/search
484daea
@phil-davis
chore: set introductionVersion 5.0 in services/settings
3d1bea5
@phil-davis
chore: set introductionVersion 5.0 in services/sharing
5c4e049
@phil-davis
chore: set introductionVersion 5.0 in services/sse
6d8d9d4
@phil-davis
chore: set introductionVersion 5.0 in services/storage-system -users
3dbd480
@phil-davis
chore: set introductionVersion 5.0 in services/userlog
d239d9d
@phil-davis
chore: set introductionVersion 5.0 in services/web
6a00b76
@dragonchaser @phil-davis
Update services/clientlog/pkg/config/config.go
546f79f
@phil-davis @micbar
Adjust introductionVersion pre5.0 and 5.0
fe8a303 
as per suggestions by micbar

Co-authored-by: Michael Barz <[email protected]>
@mmattel @phil-davis
[docs-only] Fix added envars table
9610865
@mmattel @phil-davis
[docs-only] And more envvars that are added to the table
f3ea7d0
@mmattel @phil-davis
[docs-only] More updates to the added envvar tables
ab056d1
@mmattel @phil-davis
[docs-only] Finally fixed the added tables, 2 envvars were accidentia…
a5497b0 
…lly deleted
@phil-davis
chore: adjust env-var-deltas/4.0.0-5.0.0-added
4c78402
@phil-davis
chore: remove duplicate FRONTEND_OCS_STAT_CACHE_AUTH_USERNAME from docs
fc8b4aa
@phil-davis phil-davis force-pushed the backport/env-var-introductionVersion branch from 728f8ab to fc8b4aa Compare March 7, 2024 08:07
@phil-davis phil-davis mentioned this pull request Mar 7, 2024
Merged
@phil-davis
Copy link
Contributor Author

Backport of #8601 has been added.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dragonchaser dragonchaser merged commit 3ec951c into stable-5.0 Mar 7, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the backport/env-var-introductionVersion branch March 7, 2024 10:30
ownclouders pushed a commit that referenced this pull request Mar 7, 2024
@dragonchaser
Merge pull request #8583 from owncloud/backport/env-var-introductionV…
d7c44b9 
…ersion

[stable-5.0] chore: adjust env vars so that check-env-var-annotations passes
This was referenced Mar 11, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonchaser dragonchaser dragonchaser approved these changes

@micbar micbar micbar approved these changes

@wkloucek wkloucek Awaiting requested review from wkloucek wkloucek is a code owner

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@kulmann kulmann Awaiting requested review from kulmann

@mmattel mmattel Awaiting requested review from mmattel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phil-davis @mmattel @dragonchaser @micbar