Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport verify service accounts are set to stable 5 #8553

Closed
wants to merge 2 commits into from

Conversation

butonic
Copy link
Member

@butonic butonic commented Mar 1, 2024

backport #8546 to stable 5

butonic added 2 commits March 1, 2024 10:22
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic butonic requested a review from kulmann as a code owner March 1, 2024 09:23
Copy link

update-docs bot commented Mar 1, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

.vscode/launch.json Show resolved Hide resolved
@@ -69,3 +69,19 @@ func MissingAdminUserID(service string) error {
"the config/corresponding environment variable).",
service, defaults.BaseConfigPath())
}

func MissingServiceAccountID(service string) error {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported func MissingServiceAccountID should have a comment or be unexported

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a backport and we should not add something that is not in master

service, defaults.BaseConfigPath())
}

func MissingServiceAccountSecret(service string) error {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported func MissingServiceAccountSecret should have a comment or be unexported

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a backport and we should not add something that is not in master

@@ -83,6 +83,10 @@ type FrontendService struct {
ServiceAccount ServiceAccount `yaml:"service_account"`
}

type OcmService struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported type OcmService should have a comment or be unexported

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a backport and we should not add something that is not in master

Copy link

sonarcloud bot commented Mar 1, 2024

@butonic butonic requested a review from kobergj March 1, 2024 14:13
@micbar
Copy link
Contributor

micbar commented Mar 1, 2024

@butonic @kobergj why is our linter not configured correctly to spot that missing code comment right away?

Quick win imho.

@rhafer
Copy link
Contributor

rhafer commented Mar 12, 2024

This is now part of #8627

@rhafer rhafer closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants