-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport verify service accounts are set to stable 5 #8553
Conversation
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
@@ -69,3 +69,19 @@ func MissingAdminUserID(service string) error { | |||
"the config/corresponding environment variable).", | |||
service, defaults.BaseConfigPath()) | |||
} | |||
|
|||
func MissingServiceAccountID(service string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported func MissingServiceAccountID
should have a comment or be unexported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a backport and we should not add something that is not in master
service, defaults.BaseConfigPath()) | ||
} | ||
|
||
func MissingServiceAccountSecret(service string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported func MissingServiceAccountSecret
should have a comment or be unexported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a backport and we should not add something that is not in master
@@ -83,6 +83,10 @@ type FrontendService struct { | |||
ServiceAccount ServiceAccount `yaml:"service_account"` | |||
} | |||
|
|||
type OcmService struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported type OcmService
should have a comment or be unexported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a backport and we should not add something that is not in master
Quality Gate passedIssues Measures |
This is now part of #8627 |
backport #8546 to stable 5