Backport/5.0/7885 #8544
Merged
Backport/5.0/7885 #8544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 795d0fc)
…led implementation still missed (cherry picked from commit a5b70b3)
(cherry picked from commit 796233c)
(cherry picked from commit 92fc17d)
(cherry picked from commit 877f233)
(cherry picked from commit c10d7dd)
(cherry picked from commit 5c39725)
(cherry picked from commit d48da96)
(cherry picked from commit 54226ae)
…terface After some back an forth we agreed on keeping the routes defined in a central place for now. (cherry picked from commit e7985f4)
In theory creating the driveItem to accepting a shared resource
can be done via '/v1beta1/drives/{drive-id}/item/{item-id}/children'
but there is also the simplified variant via
'/v1beta1/drives/{drive-id}/root/children' (aligned with the example
in the spec). For now we'll just implement the latter because accepting
a share will always be done via root of the sharejail drive.
(cherry picked from commit c8a89e9)
When accepting a share via 'POST /v1beta1/drives/{driveId}/root/children'
return the newly created driveItem. This driveItem wraps the accepted
remoteItem representing the shared resource (similar to the
'sharedWithMe' response.
This also refactors some of the helpers for user lookup and CS3 share to
driveItem conversion so they can be more easily shared.
(cherry picked from commit 7edc2fe)
(cherry picked from commit 35acae1)
(cherry picked from commit d38bd46)
Only accept requests against the shareJail driveID (cherry picked from commit 64f6c14)
errors.Join(errs...) ignores nil errors and returns nil if there are not errors. (cherry picked from commit f5a282c)
(cherry picked from commit 954998a)
|
micbar
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7885