Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Run phoenix UI tests with OCIS and owncloud storages #854

Closed
wants to merge 1 commit into from

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Nov 13, 2020

Fixes https://jira.owncloud.com/browse/OCIS-706 (some day - see comment below)

@phil-davis phil-davis self-assigned this Nov 13, 2020
@phil-davis phil-davis force-pushed the run-phoenix-UI-tests-with-both-storages branch from fa82930 to cd9dcbc Compare November 13, 2020 09:32
@phil-davis
Copy link
Contributor Author

The phoenix UI pipelines for "ocis" storage fail because the phoenix test code does not have any special code that knows how to cleanup user files... "under the hood" when a user is deleted and has "ocis" storage. We could add special test code to do that. But PR #755 is in progress - that will make OCIS (on both ocis and owncloud storage) delete the user files correctly when a user is deleted. When that PR is finished, then there will be no special "under the hood" stuff to do when deleting a user.

Note: the core API test code in owncloud/core does do special stuff "under the hood" when deleting users. It has the tricks for what to do when the user is on "ocis" and/or "owncloud" storage. That is why the core API tests can be and are run on both storages.

@phil-davis phil-davis force-pushed the run-phoenix-UI-tests-with-both-storages branch from cd9dcbc to 01b1c6d Compare November 19, 2020 03:30
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor Author

This is blocked by PR #755 which is blocked by cs3org/cs3apis#95

@phil-davis
Copy link
Contributor Author

Need to see if there is code in cs3org/reva yet to implement the delete-home stuff - cs3org/cs3apis#95 (comment)

@phil-davis
Copy link
Contributor Author

Issue #1987 PR #1990 changes from "owncloud" to "ocis" storage for the webUI tests. We decided not to run all the tests twice - they just run with "ocis" storage now.

@phil-davis phil-davis closed this May 7, 2021
@phil-davis phil-davis deleted the run-phoenix-UI-tests-with-both-storages branch May 7, 2021 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant