-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci]Added tests for sharing with all allowed roles for the list permissions #8477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
SagarGi
force-pushed
the
SharingNg/check_allowed_roles
branch
4 times, most recently
from
February 21, 2024 04:07
081d3af
to
9379c24
Compare
SagarGi
requested review from
amrita-shrestha,
nabim777,
S-Panta,
PrajwolAmatya and
nirajacharya2
February 21, 2024 04:14
This PR is blocked until what is expected in the response. An issue regarding it it made here #8331. So putting it in blocked until it gets fixed. |
Quality Gate passedIssues Measures |
saw-jan
reviewed
Feb 21, 2024
saw-jan
reviewed
Feb 21, 2024
saw-jan
reviewed
Feb 21, 2024
SagarGi
force-pushed
the
SharingNg/check_allowed_roles
branch
2 times, most recently
from
April 15, 2024 10:23
e349a5c
to
0b1816f
Compare
SagarGi
force-pushed
the
SharingNg/check_allowed_roles
branch
from
April 15, 2024 11:07
afb5d44
to
d1adc52
Compare
saw-jan
reviewed
Apr 15, 2024
saw-jan
reviewed
Apr 15, 2024
saw-jan
reviewed
Apr 15, 2024
saw-jan
reviewed
Apr 15, 2024
SagarGi
force-pushed
the
SharingNg/check_allowed_roles
branch
from
April 16, 2024 03:59
d1adc52
to
cf9e4ce
Compare
saw-jan
approved these changes
Apr 16, 2024
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
SagarGi
force-pushed
the
SharingNg/check_allowed_roles
branch
2 times, most recently
from
April 17, 2024 04:24
b83ce11
to
56ed59b
Compare
Signed-off-by: [email protected] <[email protected]>
SagarGi
force-pushed
the
SharingNg/check_allowed_roles
branch
from
April 17, 2024 04:26
56ed59b
to
349b2c0
Compare
Quality Gate passedIssues Measures |
ownclouders
pushed a commit
that referenced
this pull request
Apr 17, 2024
…or the list permissions (#8477) * Added tests for sharing with all allowed roles for the list permissions Signed-off-by: [email protected] <[email protected]> * Refactor code Signed-off-by: [email protected] <[email protected]> * Rebase and refactor code Signed-off-by: [email protected] <[email protected]> * Review address Signed-off-by: [email protected] <[email protected]> * Rebase code Signed-off-by: [email protected] <[email protected]> --------- Signed-off-by: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a tests to share invitation for all the
allowed roles
that are listed from the permission list forsharingNG
for a file and a folder.Related Issue:
#8336