Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] add test for listing file/folder permissions in personal and project space #8476

Merged
merged 1 commit into from
Apr 16, 2024
Merged

[tests-only][full-ci] add test for listing file/folder permissions in personal and project space #8476

merged 1 commit into from
Apr 16, 2024

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Feb 16, 2024 •
edited
Loading

Description

this pr adds test for listing permissions of resource in personal and project space

added scenarios

Scenario: user lists permissions of a file in personal space via the Graph API
Scenario: user lists permissions of a folder in project space via the Graph API
Scenario: user lists permissions of a file in project space via the Graph API

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • locally
  • ci

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Feb 16, 2024
@nirajacharya2 nirajacharya2 mentioned this pull request Feb 16, 2024
Closed
18 tasks
@nirajacharya2 nirajacharya2 force-pushed the list-perm branch 3 times, most recently from 138e8b8 to 90315ca Compare February 19, 2024 10:54
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@nirajacharya2 nirajacharya2 marked this pull request as ready for review February 20, 2024 03:08
@nirajacharya2 nirajacharya2 mentioned this pull request Feb 20, 2024
Open
34 tasks
@saw-jan saw-jan changed the title [tests-only][full-ci] adding test for listing filae and folder permissions in personal and project sapce [tests-only][full-ci] add test for listing file/folder permissions in personal and project space Feb 21, 2024
@nabim777 nabim777 marked this pull request as draft March 25, 2024 05:39
@nirajacharya2
Copy link
Contributor Author

nirajacharya2 commented Apr 8, 2024 •
edited
Loading

This PR is blocked until issue #8331 is fixed. So putting it in blocked until it gets fixed.

@nirajacharya2 nirajacharya2 force-pushed the list-perm branch 3 times, most recently from 2ae7405 to 30bd2d2 Compare April 15, 2024 09:49
@nirajacharya2 nirajacharya2 marked this pull request as ready for review April 15, 2024 11:02
SagarGi
SagarGi reviewed Apr 15, 2024
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM 👍

tests/acceptance/features/apiSharingNg/listPermissions.feature

@issues-8331
Scenario: user lists permissions of a file in personal space via the Graph API
Given user "Alice" has uploaded file with content "hello world" to "/textfile0.txt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Given user "Alice" has uploaded file with content "hello world" to "/textfile0.txt"
Given using spaces DAV path
And user "Alice" has uploaded file with content "hello world" to "/textfile0.txt"

if it is needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't need it because we are not working with spaces in this scenario

@nirajacharya2 nirajacharya2 requested a review from SagarGi April 16, 2024 04:56
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit b0a7f74 into master Apr 16, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the list-perm branch April 16, 2024 12:37
ownclouders pushed a commit that referenced this pull request Apr 16, 2024
@nirajacharya2
adding test for listing filae and folder permissions in personal and …
c26c4e9 
…project space (#8476)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@SagarGi SagarGi Awaiting requested review from SagarGi

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nirajacharya2 @SagarGi @saw-jan