Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-only] fix test: secret file drop #8435

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

ScharfViktor
Copy link
Contributor

fix test coreApiSharePublicLink2/uploadToPublicLinkShare.feature:13 after #8340

closed bugs:

Copy link

update-docs bot commented Feb 12, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor requested a review from saw-jan February 12, 2024 14:11
@ScharfViktor
Copy link
Contributor Author

Comment on lines 17 to 22
| permissions | create |
| password | %public% |
When the public uploads file "test.txt" with password "%public%" and content "test" using the new public WebDAV API
Then the HTTP status code should be "201"
And the content of file "/FOLDER/test.txt" for user "Alice" should be "test"
When the public uploads file "test.txt" with password "%public%" and content "test2" using the new public WebDAV API
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have a duplicate scenario here. we can remove this one

Suggested change
| permissions | create |
| password | %public% |
When the public uploads file "test.txt" with password "%public%" and content "test" using the new public WebDAV API
Then the HTTP status code should be "201"
And the content of file "/FOLDER/test.txt" for user "Alice" should be "test"
When the public uploads file "test.txt" with password "%public%" and content "test2" using the new public WebDAV API

and keep the last scenario

Scenario: uploading same file to a public upload-write and no edit and no overwrite share multiple times with new public API
Given user "Alice" has created a public link share with settings
| path | FOLDER |
| permissions | uploadwriteonly |
| password | %public% |
When the public uploads file "test.txt" with password "%public%" and content "test" using the new public WebDAV API
Then the HTTP status code should be "201"
And the following headers should match these regular expressions
| ETag | /^"[a-f0-9:\.]{1,32}"$/ |
When the public uploads file "test.txt" with password "%public%" and content "test2" using the new public WebDAV API
Then the HTTP status code should be "201"
And the content of file "/FOLDER/test.txt" for user "Alice" should be "test"
And the content of file "/FOLDER/test (2).txt" for user "Alice" should be "test2"

@ScharfViktor ScharfViktor requested a review from saw-jan February 12, 2024 19:59
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit 613ce15 into master Feb 13, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fixTestSecretUploadFile branch February 13, 2024 05:20
ownclouders pushed a commit that referenced this pull request Feb 13, 2024
* fix test: secret file drop

* Update uploadToPublicLinkShare.feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants