Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] add tests to list space files shared with group when auto sync is disable #8414

Merged
merged 1 commit into from
Feb 16, 2024
Merged

[tests-only][full-ci] add tests to list space files shared with group when auto sync is disable #8414

merged 1 commit into from
Feb 16, 2024

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Feb 9, 2024 •
edited
Loading

Description

In this PR following scenarios are added related to sharingNG:

-   Scenario: group member lists the file shared with them from project-space when auto-sync is disabled
-   Scenario: group member lists the space folder shared with them from project-space when auto-sync is disabled

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 self-assigned this Feb 9, 2024
@nabim777 nabim777 force-pushed the add-test-for-auto-accept-in-projectSpace-with-group branch 2 times, most recently from a35b6be to 51316cb Compare February 9, 2024 04:09
@nabim777 nabim777 changed the title [tests-only][full-ci] add tests to list space files shared with group when auto sync is dis… [tests-only][full-ci] add tests to list space files shared with group when auto sync is disable Feb 9, 2024
@nabim777 nabim777 force-pushed the add-test-for-auto-accept-in-projectSpace-with-group branch from 51316cb to 4ac62c0 Compare February 9, 2024 07:28
@nabim777 nabim777 mentioned this pull request Feb 9, 2024
Closed
12 tasks
@nabim777 nabim777 force-pushed the add-test-for-auto-accept-in-projectSpace-with-group branch from 4ac62c0 to d0b6cf3 Compare February 9, 2024 07:31
@nabim777 nabim777 force-pushed the add-test-for-auto-accept-in-projectSpace-with-group branch from d0b6cf3 to fa85eb9 Compare February 9, 2024 12:13
@S-Panta
Copy link
Contributor

S-Panta commented Feb 12, 2024

LGTM

@nabim777 nabim777 force-pushed the add-test-for-auto-accept-in-projectSpace-with-group branch 3 times, most recently from 1fd1742 to 971fd23 Compare February 13, 2024 04:47
saw-jan
saw-jan reviewed Feb 13, 2024
View reviewed changes
tests/acceptance/features/apiSharingNg/sharedWithMe.feature Outdated


Scenario: group member lists the file shared with them when auto-sync is disabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This scenario is for project space so would be better to indicate that in scenario title

Suggested change
Scenario: group member lists the file shared with them when auto-sync is disabled
Scenario: group member lists the file shared with them when auto-sync is disabled

@nabim777 nabim777 force-pushed the add-test-for-auto-accept-in-projectSpace-with-group branch 3 times, most recently from 979efaf to 2dc80e7 Compare February 15, 2024 10:35
@nabim777 nabim777 requested a review from saw-jan February 15, 2024 10:35
@nabim777 nabim777 force-pushed the add-test-for-auto-accept-in-projectSpace-with-group branch from 2dc80e7 to aea405b Compare February 15, 2024 11:52
@nabim777 nabim777 requested a review from SagarGi February 15, 2024 11:53
saw-jan
saw-jan approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

SagarGi
SagarGi approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SagarGi SagarGi merged commit 06f9776 into master Feb 16, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the add-test-for-auto-accept-in-projectSpace-with-group branch February 16, 2024 03:36
ownclouders pushed a commit that referenced this pull request Feb 16, 2024
@nabim777
add tests to list space files shared with group when auto sync is dis…
049c3db 
…able (#8414)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SagarGi SagarGi SagarGi approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nabim777 @S-Panta @SagarGi @saw-jan @amrita-shrestha @nirajacharya2