Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] add tests to list space file shared with them when sync is disabled #8406

Merged
merged 1 commit into from
Feb 15, 2024
Merged

[tests-only][full-ci] add tests to list space file shared with them when sync is disabled #8406

merged 1 commit into from
Feb 15, 2024

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Feb 8, 2024 •
edited
Loading

Description

In this PR following scenarios are added related to sharingNG:

- Scenario: user lists file shares shared with them from project-space when auto-sync is disabled
- Scenario: user lists folder shares shared with them from project-space when auto-sync is disabled

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 self-assigned this Feb 8, 2024
@nabim777 nabim777 mentioned this pull request Feb 8, 2024
Closed
12 tasks
@nabim777 nabim777 force-pushed the add-test-for-auto=accept-in-projectSpace branch from aa19f66 to 5009b3a Compare February 8, 2024 11:38
@nabim777 nabim777 force-pushed the add-test-for-auto=accept-in-projectSpace branch from 5009b3a to 844ca12 Compare February 9, 2024 06:47
@nabim777 nabim777 force-pushed the add-test-for-auto=accept-in-projectSpace branch 2 times, most recently from 217caf4 to 4fdc4ca Compare February 9, 2024 10:10
@nabim777 nabim777 force-pushed the add-test-for-auto=accept-in-projectSpace branch 2 times, most recently from 1b82912 to b8fe9e3 Compare February 12, 2024 04:03
@nabim777 nabim777 requested a review from S-Panta February 12, 2024 04:06
@nabim777 nabim777 force-pushed the add-test-for-auto=accept-in-projectSpace branch 2 times, most recently from f4f15fc to 5cf126a Compare February 13, 2024 05:18
@nabim777 nabim777 force-pushed the add-test-for-auto=accept-in-projectSpace branch 3 times, most recently from 1c38f4a to 261baee Compare February 13, 2024 07:35
saw-jan
saw-jan requested changes Feb 13, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After #8443 is merged

@nabim777 nabim777 force-pushed the add-test-for-auto=accept-in-projectSpace branch 2 times, most recently from 3b80381 to 25345cc Compare February 13, 2024 11:28
@nabim777 nabim777 requested a review from saw-jan February 13, 2024 11:29
@nabim777 nabim777 force-pushed the add-test-for-auto=accept-in-projectSpace branch from 25345cc to 28fb7ba Compare February 14, 2024 03:57
@nabim777 nabim777 requested a review from saw-jan February 14, 2024 03:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

saw-jan
saw-jan approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amrita-shrestha
amrita-shrestha approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nabim777 nabim777 merged commit 2a4c18e into master Feb 15, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the add-test-for-auto=accept-in-projectSpace branch February 15, 2024 05:36
ownclouders pushed a commit that referenced this pull request Feb 15, 2024
@nabim777
add tests to list space file shared with them when sync is disabled (#…
445a39a 
…8406)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrita-shrestha amrita-shrestha amrita-shrestha approved these changes

@saw-jan saw-jan saw-jan approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@grgprarup grgprarup Awaiting requested review from grgprarup

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@S-Panta S-Panta Awaiting requested review from S-Panta

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nabim777 @grgprarup @saw-jan @amrita-shrestha @S-Panta @PrajwolAmatya @nirajacharya2