-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak go-micro behavior #840
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I am tempted to press merge, but there is no changelog. |
yes, please do not merge yet, still got changes. I should get in the habit of drafting PR's :) |
I dismissed the reviews/approvals since you added commits. Ready for review? :-) |
@kulmann sure! |
Works on openSUSE Tumbleweed with etcd started by systemd from the (manually fixed) package. Seeing this log line in the sys logs tells me that etcd is really used:
Uploading funny gif works, trying to view it results in an rather unfunny experience ;-) |
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
There are a few building blocks that we were relying on default behavior, such as
micro.Registry
and the go-micro client. In order for oCIS to work in any environment and not relying in black magic configuration or running daemons we need to be able to:This PR is relying on 2 env variables from Micro:
MICRO_REGISTRY
andMICRO_REGISTRY_ADDRESS
. The latter does not make sense to provide if the registry is notetcd
.The current implementation only accounts for
mdns
andetcd
registries, defaulting tomdns
when not explicitly defined to useetcd
.The new custom client raises the timeout from 5 to 10 seconds.
Try It!
> MICRO_REGISTRY=etcd go run cmd/ocis/main.go server
TODO:
com.owncloud.api.storage
using mdnsDisclaimer:
When using
etcd
deregistering services might take a while.