Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add calendar and contacts service #8357

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

feat: add calendar and contacts service #8357

wants to merge 17 commits into from

Conversation

DeepDiver1975
Copy link
Member

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs Update Docs
Copy link

update-docs bot commented Feb 2, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

butonic
butonic reviewed Feb 2, 2024
View reviewed changes
services/caldav/pkg/service/v0/service.go Outdated

m.Route(options.Config.HTTP.Root, func(r chi.Router) {
r.Use(middleware.StripSlashes)
r.Mount("/.well-known/caldav", &caldavHandler)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to add any routes to the proxy.

@DeepDiver1975 DeepDiver1975 mentioned this pull request Feb 8, 2024
Merged
@mmattel
Copy link
Contributor

mmattel commented Feb 9, 2024

Though currently in draft mode, you should right, now as discussed, change the service name and all that what comes along including envvar names. This makes it easier afterewards...

@DeepDiver1975 DeepDiver1975 force-pushed the feat/caldav branch 16 times, most recently from edc1645 to 26341de Compare February 9, 2024 16:19
@DeepDiver1975 DeepDiver1975 changed the title feat: add caldav feat: add calendar and contacts service Feb 12, 2024
@DeepDiver1975 DeepDiver1975 force-pushed the feat/caldav branch 5 times, most recently from 2e6e7dc to 1a06aab Compare February 12, 2024 18:42
@DeepDiver1975 DeepDiver1975 marked this pull request as ready for review February 12, 2024 18:42
@DeepDiver1975
Copy link
Member Author

How does it work without Basic Auth?

no - we need some app passwords .... there is an issue for it ...

@dj4oC
Copy link
Contributor

dj4oC commented Feb 22, 2024

How does it work without Basic Auth?

no - we need some app passwords .... there is an issue for it ...

I understood that that would slow down very much. Is this still true?

@micbar
Copy link
Contributor

micbar commented Feb 22, 2024 •
edited
Loading

I understood that that would slow down very much. Is this still true?

Thats for basic auth.

we are not targeting basic auth here. see #7711

@DeepDiver1975
Copy link
Member Author

we are not targeting basic auth here. see #7711

thx - this is the issue I was looking for ...

basic auth is required in terms of the http authentication mechanism.

@DeepDiver1975 DeepDiver1975 force-pushed the feat/caldav branch 3 times, most recently from d479625 to 7d52439 Compare March 8, 2024 14:46
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
15 New Bugs (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@DeepDiver1975
feat: add caldav
19f8aba
@DeepDiver1975
test: add caldavtester
0ca01c1
@DeepDiver1975
feat: add caldavtester to drone
bbd5872
@DeepDiver1975
feat: caldav -> ccs
61589c9
@DeepDiver1975
fix: test
d96d861
@DeepDiver1975
chore: organize ccs tests under test/ccs
d13b4bc
@DeepDiver1975
feat: implement ccs backend on metadata storage service
b1dd1f8
@DeepDiver1975
fix: calendar listing and not found error scenarios
d29fb1e
@DeepDiver1975
feat: implement carddav + cli commands to create calendars and addres…
b198ba6 
…sbooks
@DeepDiver1975
drone: setup calendars and address books in own step
b2a932e
@DeepDiver1975
fix: carddav
63a8387
@DeepDiver1975
fix: more caldav and carddav tests
0b0af77
@DeepDiver1975
feat: move all ccs from /dav/ to /ccs/
b391b39
@DeepDiver1975
docs: add ccs docs skeleton
c488dfa
@DeepDiver1975
fix: AddressBookHomeSetPath
9b7ca6d
@DeepDiver1975
fix: dav feature detection on /ccs - allows DAVx5 to connect to OCIS …
eb313f2 
…single binary when pointing it to /ccs
@DeepDiver1975
chore: move to github.com/DeepDiver1975/go-webdav
ac63a03
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8 New Bugs (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@DeepDiver1975 DeepDiver1975 mentioned this pull request Apr 25, 2024
Closed
9 tasks
@DeepDiver1975 DeepDiver1975 mentioned this pull request May 6, 2024
Merged
25 tasks
@micbar micbar mentioned this pull request Jun 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic left review comments

@micbar micbar Awaiting requested review from micbar

@phil-davis phil-davis Awaiting requested review from phil-davis phil-davis is a code owner

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DeepDiver1975 @mmattel @dj4oC @micbar @butonic