Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only]: fix test expectations for cors #8279

Merged
merged 1 commit into from
Jan 24, 2024
Merged

[tests-only]: fix test expectations for cors #8279

merged 1 commit into from
Jan 24, 2024

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Jan 24, 2024

Description

Fix test expectations for CORS

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@micbar micbar requested a review from ScharfViktor January 24, 2024 14:43
@micbar micbar force-pushed the enable-cors-tests branch 2 times, most recently from 098ab23 to 2abc3ae Compare January 24, 2024 14:53
@micbar micbar force-pushed the enable-cors-tests branch from 2abc3ae to 174c12d Compare January 24, 2024 15:07
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@micbar micbar requested a review from 2403905 January 24, 2024 15:50
ScharfViktor
ScharfViktor approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we close then #5195 #5194

@ScharfViktor ScharfViktor merged commit 0cb731a into master Jan 24, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the enable-cors-tests branch January 24, 2024 15:52
ownclouders pushed a commit that referenced this pull request Jan 24, 2024
@micbar
tests: fix test expectations for cors (#8279)
330373b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@2403905 2403905 Awaiting requested review from 2403905

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micbar @ScharfViktor