Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-only] add more CORS tests #8254

Merged
merged 1 commit into from
Jan 24, 2024
Merged

[test-only] add more CORS tests #8254

merged 1 commit into from
Jan 24, 2024

Conversation

ScharfViktor
Copy link
Contributor

We had CORS tests only for OCS api but test is skipped because: #5195

I added tests for graph api(lists all available spaces) and webDave(propfind request). I'm not sure that I need cover all endpoints. If I wrong please point it out to me in the review

Copy link

update-docs bot commented Jan 19, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! Could we add the settings API also?

@ScharfViktor
Copy link
Contributor Author

Nice improvement! Could we add the settings API also?

yes. I'll do it in the next PR

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ScharfViktor ScharfViktor merged commit ee6f155 into master Jan 24, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Jan 24, 2024
ownclouders pushed a commit that referenced this pull request Jan 25, 2024
@ScharfViktor ScharfViktor deleted the addMoreCORStests branch April 17, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants